Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranks reverting to Second Star League #2442

Closed
BowtieBob opened this issue Feb 26, 2021 · 3 comments · Fixed by #2444
Closed

Ranks reverting to Second Star League #2442

BowtieBob opened this issue Feb 26, 2021 · 3 comments · Fixed by #2444
Assignees
Milestone

Comments

@BowtieBob
Copy link

Environment

What version of MekHQ does your issue apply to? 0.47.17
What operating system are you using? Windows
What java version are you using? AdoptOpenJDK version 11.0.9.1

Description

After setting my rank system to First Star League, the rank structure will eventually change back to Second Star League instead.
image
Note the Lieutenant rank of the First Star League, but the Rank System in the drop down says Second Star League. This is after reloading my campaign.

image
The drop down now shows "Second Star League" in the location that "First Star League" used to be. If I chose this option (or the one at the top of the list), the ranks change to Second Star League ranks.

image
Reloaded after changing to Federated Suns ranks.

image
Here is the text from the .cpnx file after changing to "First Star League" ranks

image
Here is the text from the .cpnx file after changing to "Federated Suns" ranks

The ranks are actually showing correctly when I open the campaign, but I have noticed that it will eventually switch back to the actual Second Star League ranks (I'm not sure what actually causes that to happen yet)

Files

Devestators30250409-1SL.cpnx.zip
This has a save with Fed Suns ranks and another with 1st Star League ranks.

@Windchild292
Copy link
Contributor

This was a bugfix, behaviour is expected, and no new migration will be added.

@BowtieBob
Copy link
Author

How is it expected behavior for the ranks to continually switch back to second star league on their own?

@Windchild292 Windchild292 reopened this Feb 26, 2021
@Windchild292 Windchild292 added Can't Reproduce Needs Investigation This issue needs investigation and/or triage. Ranks labels Feb 26, 2021
@Windchild292 Windchild292 self-assigned this Feb 26, 2021
@Windchild292 Windchild292 added this to the 0.48-stable milestone Feb 26, 2021
@Windchild292 Windchild292 added Blocker and removed Can't Reproduce Needs Investigation This issue needs investigation and/or triage. labels Feb 26, 2021
@monbvol
Copy link

monbvol commented May 2, 2021

This still seems to happen with some campaigns on version 0.49 but not all.

https://www.mediafire.com/file/x1sa58s1t4vw8km/SecondStarLeague.mp4/file

May come down to how the Custom ranks are handled now versus previous versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants