-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
47.13 Certain awards cause personnel information to blank #2220
Comments
Caused by #2161, namely that Image::getWidth and Image::getHeight are returning -1 for an unknown reason.
|
There is a chance this is because the files in question are erroneous, however I believe it to be because they are using currently unsupported png formats. I've got a temporary fix that will hold for now, but will need to be revisited once we upgrade to Java 11. This has been noted in the file in question. |
@Windchild292, if I saved the award images in the wrong format, please let me know how to do it properly and I will convert them all. |
It is pre-existing, this was just found because of a few underlying changes I made to standardize and simplify the backend for icons in general. If it persists after the Java version swapover I'll let you know and we can try to figure out why awards are being parsed differently. |
47.13
Linux
Java 11.0.8
Clean install with no modifications or customization, there appear to be some awards which cause information (Mechwarrior, Status, Origin, Age, Skill Names, etc.) to disappear from within the personnel display on the upper right side of the screen.
I noticed this issue when attempting to import my custom award set to 47.12 and, in addition to the blank personnel screen detailed above, some of the ribbons from my custom set also failed to display. (log and custom awards file from that attempt have not been included here)
The issue can be recreated using various awards from the 'standard' set as demonstrated here using the 'Medal of Honor' award featured in the attached screenshots.
mekhqlog.txt
The text was updated successfully, but these errors were encountered: