From a4e9dafe9f2d4ff674c6103d2092964d14061f37 Mon Sep 17 00:00:00 2001 From: unknown Date: Thu, 12 Aug 2021 21:23:02 -0400 Subject: [PATCH] code review changes --- MekHQ/data/scenariomodifiers/HostileBVBudgetIncrease.xml | 2 +- .../mekhq/campaign/mission/AtBDynamicScenarioFactory.java | 4 ++-- MekHQ/src/mekhq/campaign/stratcon/StratconTrackState.java | 8 +------- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/MekHQ/data/scenariomodifiers/HostileBVBudgetIncrease.xml b/MekHQ/data/scenariomodifiers/HostileBVBudgetIncrease.xml index 381c1d258a..3cf0ca0a37 100644 --- a/MekHQ/data/scenariomodifiers/HostileBVBudgetIncrease.xml +++ b/MekHQ/data/scenariomodifiers/HostileBVBudgetIncrease.xml @@ -1,6 +1,6 @@ Local coordination has allowed the opposition to deploy a larger force to respond to your presence. - fakse + false PreForceGeneration Opposing -1 diff --git a/MekHQ/src/mekhq/campaign/mission/AtBDynamicScenarioFactory.java b/MekHQ/src/mekhq/campaign/mission/AtBDynamicScenarioFactory.java index c4ff0ad0b1..523964736b 100644 --- a/MekHQ/src/mekhq/campaign/mission/AtBDynamicScenarioFactory.java +++ b/MekHQ/src/mekhq/campaign/mission/AtBDynamicScenarioFactory.java @@ -1943,8 +1943,8 @@ private static void setDeploymentTurns(AtBDynamicScenario scenario) { /** * Sets up deployment turns for all bot units within the specified bot force according to the specified force template's rules. - * @param botForce The bot force to process - * @param deployRound The specific deployment round, or a special constant. + * Also makes use of the given scenarios reinforcement delay modifier. + * * ARRIVAL_TURN_STAGGERED_BY_LANCE is not implemented. * ARRIVAL_TURN_STAGGERED is processed just prior to scenario start instead (?) */ diff --git a/MekHQ/src/mekhq/campaign/stratcon/StratconTrackState.java b/MekHQ/src/mekhq/campaign/stratcon/StratconTrackState.java index 0781e7d0ff..3f07720dde 100644 --- a/MekHQ/src/mekhq/campaign/stratcon/StratconTrackState.java +++ b/MekHQ/src/mekhq/campaign/stratcon/StratconTrackState.java @@ -408,13 +408,7 @@ public void failObjective(StratconCoords coords) { * Whether or not this track has a facility on it that reveals the track. */ public boolean hasActiveTrackReveal() { - for (StratconFacility facility : getFacilities().values()) { - if (facility.getRevealTrack()) { - return true; - } - } - - return false; + return getFacilities().values().stream().anyMatch(facility -> facility.getRevealTrack()); } /**