[0.49.17] Modifier for BAP shooting through woods shows up in wrong places

[EvilAtlas]

Environment

MegaMek version 0.49.17, packaged with MekHQ
Windows 11
Java 11.0.14.1

Description

During the shooting phase, in the section of the unit window where accuracy modifiers are displayed, mechs firing through woods were given the "target behind woods and attacker has BAP" modifier despite none of the mechs having BAPs or pilots with SPAs. I am not yet sure whether this was actually affecting accuracy or if it was just a display bug.

That modifier also appeared, clearly erroneously, in the firing results list. Where it should just state a to-hit number it instead includes "behind woods and attacker has BAP)'>" before that number.

To reproduce, just load into the game and find a position where you'll be shooting through woods. (This should be easy.)

Files

megamek.log
BAPbugsave.sav.gz
Player name: Evil Atlas

[kuronekochomusuke]

duplicate of #5030