Bugfix checkboxes behavior when search or filters are active #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the search or filter is active, we must display the count of checked rows only for "visible" items (results of search or filtered results). Therefore, the toggleSelectAll() method must also check or uncheck all "visible" items when the search or filters are active.
thyseus
reviewed
Nov 17, 2022
| @@ -1620,14 +1635,38 @@ public function checkboxQuery() | |||
|
|
|||
| public function toggleSelectAll() | |||
| { | |||
| if (count($this->selected) === $this->getQuery()->getCountForPagination()) { | |||
| $this->selected = []; | |||
| $visible_chekboxes = $this->getQuery()->get()->pluck('checkbox_attribute')->toArray(); | |||
There was a problem hiding this comment.
typo: please call this variable $visible_checkboxes.
There was a problem hiding this comment.
Sorry, I just corrected it. You've a good eagle eye 😄
|
@renardudezert thanks a lot for your work, will merge once you fixed that minor typo ! |
|
You're welcome. It is a good project, the contributions are deserved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the search or filter is active, we must display the count of checked rows only for "visible" items (results of search or filtered results). Therefore, the toggleSelectAll() method must also check or uncheck all "visible" items when the search or filters are active.
See the gif below in order to view the correct behavior (what this PR brings)