Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): disable pointer event on svg #125

Merged
merged 5 commits into from
Dec 26, 2018

Conversation

liuderchi
Copy link
Member

@liuderchi liuderchi commented Dec 25, 2018

To diable pointer event on svg elements to prevent trigger dialog onHide

  • InputCheckbox
  • Popover
  • Tooltip

@netlify
Copy link

netlify bot commented Dec 25, 2018

success

Built with commit 9a952ca

https://deploy-preview-125--mcs-ui.netlify.com

@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #125 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   89.31%   89.34%   +0.02%     
==========================================
  Files         165      165              
  Lines         777      779       +2     
  Branches       61       61              
==========================================
+ Hits          694      696       +2     
  Misses         73       73              
  Partials       10       10
Impacted Files Coverage Δ
src/Popover/Popover.js 66.66% <ø> (ø) ⬆️
src/Checkbox/styled-components.js 100% <ø> (ø) ⬆️
src/Tooltip/Tooltip.js 66.66% <ø> (ø) ⬆️
src/Popover/styled-components.js 50% <100%> (+16.66%) ⬆️
src/Tooltip/styled-components.js 66.66% <100%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d9974...9a952ca. Read the comment docs.

@liuderchi liuderchi force-pushed the feat/checkbox-svg-no-pointer-event branch from 941d290 to 5451ed2 Compare December 25, 2018 10:20
@liuderchi liuderchi force-pushed the feat/checkbox-svg-no-pointer-event branch from 5451ed2 to f785ef8 Compare December 25, 2018 10:31
src/Popover/Popover.js Outdated Show resolved Hide resolved
src/Popover/Popover.js Outdated Show resolved Hide resolved
src/Popover/Popover.example.js Outdated Show resolved Hide resolved
@liuderchi liuderchi merged commit f555897 into master Dec 26, 2018
@liuderchi liuderchi deleted the feat/checkbox-svg-no-pointer-event branch December 26, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants