Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the MBEDTLS_SSL_DTLS_BADMAC_LIMIT config.h option #4403

Closed
mpg opened this issue Apr 23, 2021 · 0 comments · Fixed by #4476
Closed

Remove the MBEDTLS_SSL_DTLS_BADMAC_LIMIT config.h option #4403

mpg opened this issue Apr 23, 2021 · 0 comments · Fixed by #4476
Assignees
Labels
good-first-issue Good for newcomers size-s Estimated task size: small (~2d)

Comments

@mpg
Copy link
Contributor

mpg commented Apr 23, 2021

This option is a trade-off between a feature a code size: it allows people who don't need that feature to avoid paying the cost in code size, by disabling it.

However:

Work to do:

  • remove this option and let the code behave as if it was always enabled
  • if any tests had a declared dependency on this option, remove that declaration
  • in the end git grep MBEDTLS_SSL_DTLS_BADMAC_LIMIT should find no match except in the ChangeLog, the CI should pass and no test will have been removed
@mpg mpg added good-first-issue Good for newcomers mbedtls-3 size-s Estimated task size: small (~2d) labels Apr 23, 2021
@TRodziewicz TRodziewicz self-assigned this May 10, 2021
@mpg mpg closed this as completed in #4476 May 27, 2021
@bensze01 bensze01 modified the milestone: Mbed TLS 4.0 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants