Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MBEDTLS_SSL_MAX_CONTENT_LEN #4362

Closed
chris-jones-arm opened this issue Apr 16, 2021 · 0 comments · Fixed by #4458
Closed

Remove MBEDTLS_SSL_MAX_CONTENT_LEN #4362

chris-jones-arm opened this issue Apr 16, 2021 · 0 comments · Fixed by #4458
Assignees
Labels
component-tls enhancement good-first-issue Good for newcomers size-s Estimated task size: small (~2d)

Comments

@chris-jones-arm
Copy link
Contributor

chris-jones-arm commented Apr 16, 2021

Context

The configuration option MBEDTLS_SSL_MAX_CONTENT_LEN controls the "Maximum length of incoming and outgoing plaintext fragments". Since its introduction two more finer-grained options have been introduced: MBEDTLS_SSL_IN_CONTENT_LEN and MBEDTLS_SSL_OUT_CONTENT_LEN. These two options provide exactly the same functionality as MBEDTLS_SSL_MAX_CONTENT_LEN however allow for more control over the input and output separately.


Rationale

As there are already two other config options which together provide the same functionality as MBEDTLS_SSL_MAX_CONTENT_LEN it makes sense to remove it in favour of the using the other options. Having redundant config options only leads to more chance to misconfigure and misunderstand how the options should be used to provide the desired result.

This option was previously kept to preserve API compatibility but with Mbed TLS 3.0 we no longer have that requirement and so this can now be removed from 3.0 onwards.


Work items for 3.0

  • Remove the option MBEDTLS_SSL_MAX_CONTENT_LEN from config.h.
  • Replace references to MBEDTLS_SSL_MAX_CONTENT_LEN with appropriate references to the relevant option: MBEDTLS_SSL_IN_CONTENT_LEN or MBEDTLS_SSL_OUT_CONTENT_LEN.
@chris-jones-arm chris-jones-arm added enhancement component-tls good-first-issue Good for newcomers mbedtls-3 size-s Estimated task size: small (~2d) labels Apr 16, 2021
@davidhorstmann-arm davidhorstmann-arm self-assigned this May 4, 2021
@davidhorstmann-arm davidhorstmann-arm linked a pull request May 4, 2021 that will close this issue
4 tasks
@bensze01 bensze01 modified the milestone: Mbed TLS 4.0 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-tls enhancement good-first-issue Good for newcomers size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants