Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove module: libpkcs11-helper #4078

Closed
daverodgman opened this issue Jan 27, 2021 · 1 comment · Fixed by #4254
Closed

Remove module: libpkcs11-helper #4078

daverodgman opened this issue Jan 27, 2021 · 1 comment · Fixed by #4254
Assignees
@mstarzyk-mobica
Labels
enhancement good-first-issue Good for newcomers size-s Estimated task size: small (~2d)

Comments

@daverodgman
Copy link
Contributor

Remove the wrapper for PKCS#11 library libpkcs11-helper (library/pkcs11.c).

Deprecating this module was covered in #3006, and there is some mailing list discussion here:

https://lists.trustedfirmware.org/pipermail/mbed-tls/2020-April/000024.html

This forms part of #4030

Estimated task size: S
@daverodgman daverodgman added enhancement mbedtls-3 size-s Estimated task size: small (~2d) labels Jan 27, 2021
@mpg
Copy link
Contributor

mpg commented Feb 24, 2021

Expanding on the definition of this task:

  • library/pkcs11.c and include/mbedtls/pkcs11.h are removed from the source three
  • MBEDTLS_PKCS11_C is removed from config.h and it variants
  • support for linking with libpkcs11-helper is removed from the build systems (CMake, make)
  • at the end of the task, git grep -i pkcs11 should find no occurrence except in ChangeLog entries.

@mpg mpg added the good-first-issue Good for newcomers label Mar 4, 2021
@mstarzyk-mobica mstarzyk-mobica self-assigned this Mar 22, 2021
@mstarzyk-mobica mstarzyk-mobica mentioned this issue Mar 24, 2021
Merged
@chris-jones-arm chris-jones-arm linked a pull request Mar 31, 2021 that will close this issue
Remove PKCS#11 library wrapper. #4254
Merged
This was referenced Apr 1, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstarzyk-mobica mstarzyk-mobica

Labels
enhancement good-first-issue Good for newcomers size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove PKCS#11 library wrapper. mstarzyk-mobica/mbedtls
4 participants
@mpg @daverodgman @mstarzyk-mobica @bensze01