Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary compile-time options from config.h #4035

Closed
daverodgman opened this issue Jan 14, 2021 · 4 comments
Closed

Remove unnecessary compile-time options from config.h #4035

daverodgman opened this issue Jan 14, 2021 · 4 comments

Comments

@daverodgman
Copy link
Contributor

This needs review

@yanesca
Copy link
Contributor

yanesca commented Jan 25, 2021

We are removing a number of options as part of #4031 and #4029. Some more will be moved as part of #4038. Options removed or moved as part of these are out of scope for this issue.

First step of this task should be to review config.h, make a list of options that we could remove and reach a consensus on which options to remove.

@mpg
Copy link
Contributor

mpg commented Feb 5, 2021

First step of this task should be to review config.h, make a list of options that we could remove and reach a consensus on which options to remove.

I think this is #4058 - so perhaps #4058 is about reviewing options to decide which ones to remove, and this ticket would be about actually removing them? (It's not clear to me is such a distinction was intended or if #4058 is mostly an accidental duplicate.)

@yanesca
Copy link
Contributor

yanesca commented Feb 5, 2021

I think #4058 is an accidental duplicate, I suggest we close this ticket down and keep #4058 as it is better specified.

@mpg
Copy link
Contributor

mpg commented Feb 24, 2021

Closing as a duplicated of #4058, since Janos suggesting doing so more than two weeks ago, I agree, and no-one objected in the meantime.

@mpg mpg closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants