Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /vreconnect reload #10

Open
Recliness opened this issue Sep 3, 2023 · 5 comments
Open

Add /vreconnect reload #10

Recliness opened this issue Sep 3, 2023 · 5 comments

Comments

@Recliness
Copy link

This would allow for a database refresh or something similar, in case I need to make modifications without restarting the server

@Hezkore
Copy link

Hezkore commented Sep 5, 2024

This is badly needed.

@Matt-MX
Copy link
Owner

Matt-MX commented Sep 9, 2024

I'll add this it's time to give some older projects a bit of TLC

@Matt-MX
Copy link
Owner

Matt-MX commented Sep 18, 2024

Added in dev, not tested yet since I rebased a lot of the project

@Hezkore
Copy link

Hezkore commented Sep 20, 2024

The new version does seem to properly reload the configuration file, so that's great!
However, the the actual database of players, such a data.yml, is overwritten instead of reloaded.
So modifications done to the database still requires a server restart.

@Matt-MX
Copy link
Owner

Matt-MX commented Sep 21, 2024

The new version does seem to properly reload the configuration file, so that's great! However, the the actual database of players, such a data.yml, is overwritten instead of reloaded. So modifications done to the database still requires a server restart.

Currently this is because the YAML storage will save it's data when shut down to prevent lost data.
If we don't save that data then we are able to reload properly, however will lose that data.

Would this be preferable? (I don't personally recommend using YAML tbh, and instead recommend using SQLite !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants