Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidating client service logic and lifecycle #559

Closed
tegefaulkes opened this issue Sep 13, 2023 · 1 comment · Fixed by #560
Closed

Consolidating client service logic and lifecycle #559

tegefaulkes opened this issue Sep 13, 2023 · 1 comment · Fixed by #560
Assignees
Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management r&d:polykey:supporting activity Supporting core activity

Comments

@tegefaulkes
Copy link
Contributor

Specification

We need to consolidate the client service into the client domain. This includes moving all of that logic into the client domain.

Currently we create a WebsocketServer, RPCServer and client manifest separately where needed, namely the PolykeyAgent. The creation and life-cycle of theses need to be consolidated into a ClientService class for handling all of this.

While we're here we can use the extracted RPC library once it's ready. So this can include removal of the internal RPC implementation from Polykey.

Requirements:

  1. ClientSevice will be a CreateDestroyStartStop.
  2. The ClientService will handle the life-cycle and setting up of the relevant RPCServer and WebsocketServer.
  3. ClientService will be generic on the manifest. This is required to reduce the complexity in tests.

Additional context

Tasks

  1. Create a ClientService class within the client domain.
  2. Move RPC and WebsocketServer creation and life-cycle into ClientService.
  3. PolykeyAgent will be updated to use this.
  4. tests will be updated to use this. Should reduce setup logic.
@tegefaulkes tegefaulkes added the development Standard development label Sep 13, 2023
@tegefaulkes tegefaulkes self-assigned this Sep 13, 2023
@tegefaulkes
Copy link
Contributor Author

This will be a separate PR to #552 but will be branched on top of it.

@CMCDragonkai CMCDragonkai added r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management r&d:polykey:supporting activity Supporting core activity labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management r&d:polykey:supporting activity Supporting core activity
Development

Successfully merging a pull request may close this issue.

2 participants