Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit LIMIT on queries #56

Open
joacoc opened this issue Aug 8, 2023 · 2 comments
Open

Implicit LIMIT on queries #56

joacoc opened this issue Aug 8, 2023 · 2 comments

Comments

@joacoc
Copy link
Contributor

joacoc commented Aug 8, 2023

  1. would be good to have an implicit limit on query results, maybe at 100 rows or so
@bobbyiliev
Copy link
Contributor

@joacoc Is your idea here to modify the actual SQL command before sending it to be executed? Or to just limit the results that are displayed? I could give this a go!

@joacoc
Copy link
Contributor Author

joacoc commented Oct 29, 2023

@bobbyiliev I'm unsure about what is the best solution here. We should research the most spread/common practice here. We have to options:

  1. Using the LSP to detect if there is a LIMIT. If there is none, add one.
  2. Using the LSP to detect if the SQL is a SELECT statement. If positive, use a cursor.

The LSP part is not yet implemented. It is a command method call. It would be like sending the SQL over the wire and the LSP answers back with the structure or a yes/no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants