Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PUBLIC for grantee with Default Grants #397

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Allow PUBLIC for grantee with Default Grants #397

merged 1 commit into from
Dec 6, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Dec 5, 2023

The documentation indicates that PUBLIC can be used for both target_role and grantee for default grant resources. However this was only true for target_role. Supporting grantee as well.

@dehume dehume added the bug Something isn't working label Dec 5, 2023
@dehume dehume requested a review from bobbyiliev as a code owner December 5, 2023 23:49
bobbyiliev
bobbyiliev approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@dehume dehume merged commit 7d5e5b2 into main Dec 6, 2023
6 checks passed
@dehume dehume deleted the Default-Grant-Public-Grantee branch December 6, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dehume @bobbyiliev