Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support COMMENT attribute #297

Closed
dehume opened this issue Aug 30, 2023 · 2 comments · Fixed by #324
Closed

Support COMMENT attribute #297

dehume opened this issue Aug 30, 2023 · 2 comments · Fixed by #324
Assignees
@dehume

Comments

@dehume
Copy link
Contributor

dehume commented Aug 30, 2023

Comments should be supported at the table, view and column level for objects.
@morsapaes
Copy link
Contributor

This should wait for feature stabilization, in particular for Materialize MaterializeInc/database-issues#6450 and #21451.

@dehume dehume added the icebox Tracked issues that cannot be worked on currently label Sep 1, 2023
@morsapaes
Copy link
Contributor

Now that COMMENT ON has been implemented for all object types, it's safe to start working on this. @bobbyiliev @dehume The flag should be lifted in the next two weeks!

@dehume dehume removed the icebox Tracked issues that cannot be worked on currently label Sep 21, 2023
@dehume dehume self-assigned this Sep 22, 2023
@dehume dehume linked a pull request Sep 22, 2023 that will close this issue
Attribute COMMENT #324
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehume dehume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attribute COMMENT MaterializeInc/terraform-provider-materialize
2 participants
@dehume @morsapaes