Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: track latest reported status and report on reconnect #30576

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aljoscha
Copy link
Contributor

Before, we would only pump what the dataflows reported back to the controller. Which would make it so that when a controller re-connects it doesn't get status messages for the latest state.

Now, we track the latest status update, per object, and also what has been reported, per object. And on re-connect we clear out what has been reported.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@aljoscha aljoscha force-pushed the storage-report-latest-status-on-reconnect branch from 1692ca9 to 3947a06 Compare November 20, 2024 18:20
Before, we would only pump what the dataflows reported back to the
controller. Which would make it so that when a controller re-connects it
doesn't get status messages for the latest state.

Now, we track the latest status update, per object, and also what has
been reported, per object. And on re-connect we clear out what has been
reported.
@aljoscha aljoscha force-pushed the storage-report-latest-status-on-reconnect branch from 3947a06 to c2840f6 Compare November 20, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant