Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orchestratord versions to Console instance #31564

Closed
wants to merge 1 commit into from

Conversation

SangJunBak
Copy link
Contributor

@SangJunBak SangJunBak commented Feb 20, 2025

This is to display these versions in the footer of the Console for easier debugging

Dependent on https://github.com/MaterializeInc/console/pull/3703 and a new Console release /tag.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

This is to display these versions in the footer of the Console for easier debugging
@SangJunBak
Copy link
Contributor Author

SangJunBak commented Feb 20, 2025

Would we need to patch the version of the helm chart with this change? Or do we think it's fine given the change is backwards compatible? Also we'll either need to wait for Console to cut a tag before merging this PR or create a followup PR that updates the default console image tag

@SangJunBak
Copy link
Contributor Author

Realized this is futile because of https://materializeinc.slack.com/archives/C07PN7KSB0T/p1740026859470549?thread_ts=1739991803.171899&cid=C07PN7KSB0T. Gonna close and make this a Console specific PR.

@SangJunBak SangJunBak closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant