From 02b0137fe2452426fa52a1811299f128248629bf Mon Sep 17 00:00:00 2001 From: Parker Timmerman Date: Thu, 5 Dec 2024 10:11:36 -0500 Subject: [PATCH] respond to GitHub feedback --- src/catalog/src/memory/objects.rs | 2 +- src/sql/src/plan/statement/ddl.rs | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/catalog/src/memory/objects.rs b/src/catalog/src/memory/objects.rs index 272f49269f18f..b7ab70fd9c6be 100644 --- a/src/catalog/src/memory/objects.rs +++ b/src/catalog/src/memory/objects.rs @@ -845,7 +845,7 @@ impl From for durable::Item { pub struct Table { /// Parse-able SQL that defines this table. pub create_sql: Option, - /// [`RelationDesc`] of this table, derived from the `create_sql`. + /// [`VersionedRelationDesc`] of this table, derived from the `create_sql`. pub desc: VersionedRelationDesc, /// Versions of this table, and the [`GlobalId`]s that refer to them. #[serde(serialize_with = "mz_ore::serde::map_key_to_string")] diff --git a/src/sql/src/plan/statement/ddl.rs b/src/sql/src/plan/statement/ddl.rs index bd48d1832b6ef..2096bfbad45b2 100644 --- a/src/sql/src/plan/statement/ddl.rs +++ b/src/sql/src/plan/statement/ddl.rs @@ -274,6 +274,9 @@ pub fn plan_create_table( let names: Vec<_> = columns .iter() .filter(|c| { + // This set of `names` is used to create the initial RelationDesc. + // Columns that have been added at later versions of the table will + // get added further below. let is_versioned = c .options .iter()