Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve Producer Performance #54

Closed
chuck-alt-delete opened this issue Mar 3, 2023 · 2 comments · Fixed by #64
Closed

Feature: Improve Producer Performance #54

chuck-alt-delete opened this issue Mar 3, 2023 · 2 comments · Fixed by #64
Assignees
Labels
enhancement New feature or request

Comments

@chuck-alt-delete
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Right now, we create and destroy a producer on each iteration. It would be a little more efficient to create a single producer and then disconnect when the program exits.

@chuck-alt-delete chuck-alt-delete added the enhancement New feature or request label Mar 3, 2023
@chuck-alt-delete chuck-alt-delete changed the title Feature: One producer instance per run Feature: Improve Producer Performance Mar 3, 2023
@chuck-alt-delete
Copy link
Contributor Author

chuck-alt-delete commented Mar 3, 2023

We could also consider using node-rdkafka (maintained by Blizzard) which based on the more performant librdkafka library

@sjwiesman
Copy link
Contributor

Maintaining the producer across iterations is something we should do regardless of the library.

Whether or not we switch to node-rdkafka is less important to me. This is not so high throughput in the medium term that this sort of performance is important. We should value ease of use and functionality over all else.

@bobbyiliev bobbyiliev self-assigned this Mar 7, 2023
@bobbyiliev bobbyiliev mentioned this issue Mar 7, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants