From 710dfe8001c4a53f00ffd34e682fb4a9b0b229f0 Mon Sep 17 00:00:00 2001
From: Kevin B <Keboo@users.noreply.github.com>
Date: Thu, 2 Jan 2025 22:50:39 -0800
Subject: [PATCH] Fixing issue with pipeline milestone closing not using right
 version number (#3755)

---
 .github/workflows/release.yml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 878f38f4a1..cc53f460ed 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -258,6 +258,7 @@ jobs:
         steps:
             # Doing a checkout, until this issue is resolved.
             # https://github.com/valeriobelli/gh-milestone/issues/15
+            # As of version 2.1.0 the -R doesn't appear to output valid json when filtering. So still using the checkout.
             - uses: actions/checkout@v4
 
             - name: Close Milestone
@@ -265,7 +266,7 @@ jobs:
                   gh extension install valeriobelli/gh-milestone
                   Write-Host "Using extension version $(gh milestone --version)"
                   $milestones = $(gh milestone list --json number,title) | ConvertFrom-Json
-                  $milestoneNumber = ($milestones | Where-Object { $_.title -eq "5.1.0" }).number
+                  $milestoneNumber = ($milestones | Where-Object { $_.title -eq "${{ inputs.milestone }}" }).number
                   gh milestone edit $milestoneNumber --state closed
               env:
                 GITHUB_TOKEN: ${{ secrets.SA_PAT }}
@@ -277,7 +278,7 @@ jobs:
         environment: production
 
         permissions:
-            actions: write
+          actions: write
 
         steps:
             # Checkout is needed so that we can update the get_versions.yml file