Requirements not aligned with Python versions

[j-c-cook]

Pygfunction-2.0.0 has a scipy>=1.6.2 requirement. The minimum allowable Python version in that scipy release was Python 3.7 https://pypi.org/project/scipy/1.6.2/.

[MassimoCimmino]

@j-c-cook Great catch.

Do you see a need to release a fix quickly for this? I can always update the requirement to Python 3.7 and release a v2.0.1 hotfix.

If not, I will tag it for v2.1. I will revise the milestones for v2.1 soon and move a few issues to v2.2.

[j-c-cook]

Given that there is an goodreason to be using scipy>=1.6.2, there are adequate changes to go ahead and wrap up a v2.1.

However, if we can backtrack to a scipy version that is compatible with python==3.6 and maintain the integrity of pygfunction==2.0, then I'd advocate a v2.0.1 hotfix.

[MassimoCimmino]

My proposal is to align with the Anaconda distribution for v2.1.

For the Python 3.8 3.7 release :

• numpy 1.20.1
• scipy 1.6.2
• matplotlib 3.3.4
• numpydoc 1.1.0
• sphinx 4.0.1

The latest Coolprop release is still 6.4.1.

[j-c-cook]

Did you mean to propose 3.8? I tend to not like the idea of going to another version, unless there is a reason. I agree with moving from 3.6->3.7 from pygfunction-v1.x -> pygfunction-2.x respectively for the new additions to scipy that are being used.

Looking at the same documentation, but for the Python 3.7 release:

• numpy 1.20.1
• scipy 1.6.2
• matplotlib 3.3.4
• numpydoc 1.1.0
• sphinx 4.0.1

[MassimoCimmino]

I agree with going for Python 3.7. It seems the versions are the same anyways.

[MassimoCimmino]

Looking now further into this issue, it seems the requirements was only incorrect in the README.md file:

pygfunction/README.md

Lines 44 to 54 in 0e67d4e

	*pygfunction* was developed and tested using Python 3.6. In addition, the
	following packages are needed to run *pygfunction* and its examples:
	- Coolprop (>=6.4.1)
	- matplotlib (>= 3.3.4),
	- numpy (>= 1.19.2)
	- scipy (>= 1.6.2)
	The documentation is generated using [Sphinx](http://www.sphinx-doc.org). The
	following packages are needed to build the documentation:
	- sphinx (>= 3.5.4)
	- numpydoc (>= 1.1.0)

The setup.py file correctly shows:

pygfunction/setup.py

Lines 9 to 18 in 0e67d4e

	setup(
	name="pygfunction",
	version="2.0.0",
	packages=['pygfunction',
	'pygfunction/examples'],
	include_package_data=True,
	install_requires=['coolprop>=6.4.1',
	'matplotlib>=3.3.4',
	'numpy>=1.19.2',
	'scipy>=1.6.2'],

pygfunction/setup.py

Line 37 in 0e67d4e

"Programming Language :: Python :: 3.7",

[j-c-cook]

Looks like you're right. I had seen it on PyPI, and it does look like it was only the README.