Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approximation of the finite line source #138

Closed
MassimoCimmino opened this issue Aug 11, 2021 · 3 comments · Fixed by #189
Closed

Approximation of the finite line source #138

MassimoCimmino opened this issue Aug 11, 2021 · 3 comments · Fixed by #189
Assignees
Labels

Comments

@MassimoCimmino
Copy link
Owner

This issue is to implement the approximation of the finite line source solution introduced in [1]. An option will be added to choose to evaluate the FLS using the current quadrature method or the approximation.


[1] Cimmino, M., 2021. An approximation of the finite line source solution to model thermal interactions between geothermal boreholes. International Communications in Heat and Mass Transfer, 127, p.105496.

@MassimoCimmino MassimoCimmino added this to the v2.1.0 milestone Aug 11, 2021
@MassimoCimmino MassimoCimmino self-assigned this Aug 11, 2021
@MassimoCimmino MassimoCimmino modified the milestones: v2.1.0, v2.2.0 Aug 26, 2021
@j-c-cook
Copy link
Contributor

j-c-cook commented Sep 5, 2021

Would it be possible to get this into master for the v2.1.0 release? Given that Cimmino (1) mentions a 1000x speed increase, this should provide a nice increase to calculating g-functions with accuracy.

I'd be happy to help make this happen. If you'd want to open a draft PR, I can work on it.

@MassimoCimmino MassimoCimmino modified the milestones: v2.2.0, v2.1.0 Sep 16, 2021
@MassimoCimmino MassimoCimmino modified the milestones: v2.1.0, v2.2.0 Oct 29, 2021
@MassimoCimmino
Copy link
Owner Author

MassimoCimmino commented Jan 11, 2022

equivalent solver : Rectangular fields up to 400 boreholes

Results labeled with 'PR-189' use the approximation of the FLS and nFLS=10 terms.

Figure_1

Figure_2

Figure_3

@MassimoCimmino
Copy link
Owner Author

MassimoCimmino commented Jan 12, 2022

similarities solver : Rectangular fields up to 400 boreholes

Results labeled with 'PR-189' use the approximation of the FLS and nFLS=10 terms. We can see that the calculation time is only decreased for smaller bore fields. This is expected since the solution of the system of equations is the major part of the calculation time for larger bore fields.

Figure_1b

Figure_2b

Figure_3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants