Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX Gesture navigation not working #954

Closed
Nxt3 opened this issue Apr 17, 2016 · 9 comments
Closed

OSX Gesture navigation not working #954

Nxt3 opened this issue Apr 17, 2016 · 9 comments

Comments

@Nxt3
Copy link

Nxt3 commented Apr 17, 2016

OS: OSX 10.11.3

Issue Descriptions: Three finger swipe doesn't work; also, it should be a two finger swipe as three finger swipe interferes with switching between desktop spaces.

Steps to Reproduce: Try to swipe back

@MarshallOfSound
Copy link
Owner

Yeah, I totally didn't test this. I just implemented the method (I don't have a mac). From what I can tell you need certain settings turned on in System Preferences.

You can read more about that here electron/electron#4843

As for two finger swiping, that's a different story. I can look into it but it is hard to test code without a mac

@hugomd
Copy link

hugomd commented Apr 18, 2016

@MarshallOfSound I'm happy to test it on mine if you want to send me beta builds.

@MarshallOfSound
Copy link
Owner

@hugomd It's the kind of thing that you need to muck around with numbers for. Electron doesn't actually support a "2 finger" swipe event. The way others have implemented it is to listen for the wheel event on the window. https://developer.mozilla.org/en-US/docs/Web/Events/wheel

And then use to calculate horizontal scroll velocity, determine if it should be considered a swipe, and if so use the scroll touch events in electron down and up do determine when to consider it an actual 2 finger swipe.

That velocity calculation is something that will take a lot of trial and error 👍

@Nxt3
Copy link
Author

Nxt3 commented Apr 18, 2016

Not sure if this is possible, but if you were to implement the code, I could fix the plugging/chugging of numbers and fix it for you.

@MarshallOfSound MarshallOfSound added this to the 3.3.0 milestone May 26, 2016
@MarshallOfSound
Copy link
Owner

@hugomd @Nxt3 I got my hands on a mac laptop and implemented this, if either of you are running the dev version can you pull the latest master and make sure you're OK with how it works 👍

@PierBover
Copy link

PierBover commented Jan 3, 2017

Um doesn't work for me.

I'm on 4.0.5.

Edit: Sorry, it does work, but it requires a really fast swipe compared to other apps like Chrome or Safari.

@MarshallOfSound
Copy link
Owner

Sorry, it does work, but it requires a really fast swipe compared to other apps like Chrome or Safari.

Gotta get some exercise 😆 It depends on scroll speed settings I think so it varies from device to device 😢

@PierBover
Copy link

What about implementing a setting to allow users to change the speed threshold in the prefs pane?

@MarshallOfSound
Copy link
Owner

@PierBover I don't think MUI has a slider or anything to fill that role but if someone wants to PR in something to fill that role I would consider it. Mostly I just want to avoid cluttering up the settings window so as long as whatever it is fits in nicely, doesn't take up to much space and clearly follows MDG I'll probably take it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants