-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotkeys not working for Thumbs Up/Down in YT Music #3901
Comments
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out. |
Do you happen to also have the 'Unknown Artist' problem in YTM as seen in #3888? |
Ahh, yes I do have that issue! I hadn't even noticed that. |
I'll build from source to see if that resolves the issue. |
I believe that its resolved with 6.2.2 then, I had accidentally went back to the wrong patch when testing. |
Confirmed! Building from source solved this issue, so your theory on the update for ytmusic.js is correct. |
I'm going to close this out then, as its already resolved in master. |
Hotkeys don't trigger Thumbs Up/Down in YT Music
OS: macOS 10.15.7 (19H2)
Application Version: 4.7.1 (4.7.1)
A summary of the issue. If suitable, include the steps required to reproduce the bug.
Expected result: Thumbs up/down is triggered and saved
Actual result: No effect (no highlighted thumb icon, thumbs down doesn't skip track, etc.)
Note that this issue doesn't appear to be present in Google Play Music version of the app, hotkeys work there for thumbs up/down as normal.
Per @jostrander :
There seems to be some kind of disconnect between the hot keys and ytmusic.js, but it ytmusic.js has it implemented, so it should be fine in future builds once that's resolved. A separate issue would be fine.
Originally posted by @jostrander in #3892 (comment)
The text was updated successfully, but these errors were encountered: