[Feature Request]: videojs-mobile-ui #56
Assignees
Labels
Comments
|
I like |
MarmadileManteater
added a commit
that referenced
this issue
Oct 12, 2022
- Using the beta because it fixes an issue with multiple version of videojs loading at once. This is related to #56.
|
One thing to note is that there may have to be some slight CSS changes due to the larger play/pause button that |
4 tasks
FreeTubeBot
pushed a commit
to FreeTubeApp/FreeTube
that referenced
this issue
Oct 24, 2022
* Adding videojs-mobile-ui as a dependency - Using the beta because it fixes an issue with multiple version of videojs loading at once. This is related to MarmadileManteater#56. * Mapping defaultSkipInterval to seekSeconds * Adding CSS to prevent showing duplicate buttons - Added a new variable `usingTouch` to selectively hide the existing `vjs-big-play-button` when the `touch-overlay` is visible. * Renaming CSS class to something more specific * Adding text-shadow behind play / pause button This should make it more visually distinct against a light or colorful background. * Enabling touch-overlay anytime a touch is detected Disabling it whenever mouse input is detected The default behavior of `videojs-mobile-ui` is to only work in Android and iOS, but by forcing the touch behavior to be enabled and selectively showing it only when touch input is detected, it should work on any device with touch input even if the browser doesn't detect that it is running in Android or iOS. * Removing unnecessary code * Removing unintentionally leftover variable * Removing an unnecessary assignment Adding comments to explain why a flag called `forceForTesting` is set to true Disabling the `lockOnRotate` flag. * Moving this flag and wrapper class * Adding whitespace * Making my comment a little more consistent * Changing the punctuation of a comment * Adjusting the CSS to fix a firefox discrepancy * Adding a check for mobile firefox For whatever reason, mobile firefox sometimes triggers onmouseover when a touch occurs, and this is unwanted behavior. * Adding a drop-shadow to the ff and rw icons This should make them easier to see on top of light videos * Hiding the mobile play button according to setting - Added CSS to hide the videojs-mobile-ui play button when the `Display Play Button In Video Player` setting is disabled. * Replacing long computed string with class binding Co-authored-by: absidue <[email protected]> * Adding newline at the end of videoJS.css Co-authored-by: absidue <[email protected]>
|
These changes have been pulled in from upstream as of commit a3ffbda, and they should roll out in nightly release 72. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Guidelines
Problem Description
VideoPlayer doesn't have the best mobile controls
Proposed Solution
Not sure if this would work in Cordova or not but the videojs-mobile-ui module will add touch controls (such as double tap left side to rewind & right side to fast-forward). It might be good to implement this upstream if it works with Cordova.
Alternatives Considered
None
Issue Labels
ease of use improvement, new feature
Additional Information
No response
The text was updated successfully, but these errors were encountered: