Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stopSDPrint so it works when paused #4610

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Fix stopSDPrint so it works when paused #4610

merged 2 commits into from
Aug 12, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Aug 12, 2016 •
edited
Loading

Addressing #4598

This PR fixes a longstanding bug in the CardReader class, where if a print is paused, it cannot be stopped.

Also…

  • Apply changes to reduce code size in CardReader by 230 bytes.
  • Pretty up serial macros in Marlin.h

@thinkyhead thinkyhead changed the title Fix stopSDPrint to work when paused Fix stopSDPrint so it works when paused Aug 12, 2016
@thinkyhead thinkyhead merged commit fef0e8b into MarlinFirmware:RCBugFix Aug 12, 2016
@thinkyhead thinkyhead deleted the rc_sd_pause_and_stop branch August 12, 2016 11:09
@thinkyhead thinkyhead mentioned this pull request Aug 12, 2016
Closed
@thinkyhead thinkyhead mentioned this pull request Aug 21, 2016
Closed
@thinkyhead thinkyhead mentioned this pull request Sep 2, 2016
Closed
@thinkyhead thinkyhead mentioned this pull request Oct 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug: Confirmed !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thinkyhead