E3V2/LCD: unify limits for feedrate, acc, jerk and steps #25045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazewicz
force-pushed
the
e3v2-motion-limits
branch
from
f2dfe32
to
94c2a6c
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
52a9e5e
to
7e60d15
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
a71a62c
to
250fd60
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
40e1292
to
339773d
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
2 times, most recently
from
e90c213
to
4b9bb85
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
6 times, most recently
from
27df113
to
8d31429
Compare
thinkyhead
force-pushed
the
e3v2-motion-limits
branch
from
2622534
to
7bab1ec
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
de391db
to
0f34163
Compare
thinkyhead
force-pushed
the
e3v2-motion-limits
branch
from
0846b8a
to
8419d5d
Compare
thinkyhead
force-pushed
the
e3v2-motion-limits
branch
from
8419d5d
to
65414c8
Compare
thinkyhead
force-pushed
the
e3v2-motion-limits
branch
from
65414c8
to
5626638
Compare
ncksnydr
added a commit
to ncksnydr/Narungol-Marlin-Firmware
that referenced
this pull request
May 22, 2023
… into feature/bugfix-2.1.x * 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin: (61 commits) 🔨 Fix BTT EBB42 V1.1 compile with -flto (MarlinFirmware#25849) [cron] Bump distribution date (2023-05-22) 🧑💻 Fall back to SPI0 with YHCB2004 (MarlinFirmware#25856) 🩹 Fix ProUI Manual Mesh / UBL Viewer (MarlinFirmware#25858) 🩹 Fix TFT LVGL compile error (MarlinFirmware#25865) [cron] Bump distribution date (2023-05-21) 📝 MKS TinyBee pins header 🚸 Improve EEPROM validation (MarlinFirmware#25860) [cron] Bump distribution date (2023-05-20) 🎨 Cutter pins cleanup [cron] Bump distribution date (2023-05-19) 🩹 M493 report followup ✨ I3DBEEZ9 board (MarlinFirmware#25614) 🔨 Fix Windows path backslash treated as escape [cron] Bump distribution date (2023-05-18) 🚸 Unify edit limits for some E3V2 LCDs (MarlinFirmware#25045) [cron] Bump distribution date (2023-05-17) 🐛 Fix MKS Robin Nano 1.3 F4 pin collision (MarlinFirmware#25838) 🚸 Support Bed Leveling Mesh > 16x16 🔧 TMC Config Inheritance followup (MarlinFirmware#25783) ... Signed-off-by: Nick Snyder <[email protected]> # Conflicts: # config/ncksnydr/narungol/2.1/Configuration.h
tspiva
pushed a commit
to tspiva/Marlin
that referenced
this pull request
May 25, 2023
Co-authored-by: Scott Lahteine <[email protected]>
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 15, 2023
Co-authored-by: Scott Lahteine <[email protected]>
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 18, 2023
Co-authored-by: Scott Lahteine <[email protected]>
Open
1 task
|
As it was merged this breaks all systems where |
|
@thinkyhead himm, actually I see it is this commit 5626638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently neither Creality's default, JyersUI nor ProUI LCD drivers use max values for acceleration, steps and jerk as documented in
Configuration.h.Each driver has a different way of dealing with limits which makes it hard to update. In this patch I've unified acceleration, feedrate, jerk and steps/mm limits into one file and implemented it in JyersUI, ProUI and Creality's default UI drivers.
Requirements
Ender-3 V2 with DWIN display.
Benefits
The UI limits for acceleration, feedrate, jerk and steps/mm will now observe documentation from
Configuration.h.Configurations
Any configuration for E3V2 with any of
DWIN_CREALITY_LCD,DWIN_LCD_PROUIorDWIN_CREALITY_LCD_JYERSUIenabled.Related Issues
None