-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Z-Probe variable name #3582
Comments
It's true that these options are a bit too "low level" and confusing for the average user. Some of these options might be hidden behind a simpler config system, similar to the way you now choose an LCD controller, and depending on the one you choose various other options are set. So let's mull over some possible better names. We might also be able to do something like this perhaps, in some cases: #define Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN (Z_MIN_PROBE_PIN == Z_MIN_PIN) |
I was thinking to go with Not to mention since both of these thing are located way above the auto bed leveling section; homing section that is. I also think that these option would be put under auto bed leveling section since the default hardware setup would be all min endstops anyway and be default not to use z probe. PS: |
@sarf2k4 I'm not sure what the reasoning is to use It has been suggested by others recently that we ought to move all the PROBE options out of the |
Somehow the knowledge got lost, to see the pins-files as user editable configuration files. Since splitting up the huge pin-file, you don't need witchcraft to edit them to your needs. |
To be followed up within PR #3672. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I would like to propose a name change to these
#define Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN
and//#define Z_MIN_PROBE_ENDSTOP
, the name itself is quite confusing.I'm not sure what other names but I also pointed this out at here MarlinFirmware/MarlinDocumentation#20
The text was updated successfully, but these errors were encountered: