Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-Probe variable name #3582

Closed
sarf2k4 opened this issue Apr 21, 2016 · 6 comments
Closed

Z-Probe variable name #3582

sarf2k4 opened this issue Apr 21, 2016 · 6 comments
Labels
T: Design Concept Technical ideas about ways and methods. T: Development Makefiles, PlatformIO, Python scripts, etc.

Comments

@sarf2k4
Copy link

sarf2k4 commented Apr 21, 2016

I would like to propose a name change to these #define Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN and //#define Z_MIN_PROBE_ENDSTOP, the name itself is quite confusing.

I'm not sure what other names but I also pointed this out at here MarlinFirmware/MarlinDocumentation#20

@jbrazio jbrazio added T: Development Makefiles, PlatformIO, Python scripts, etc. T: Design Concept Technical ideas about ways and methods. labels Apr 21, 2016
@thinkyhead
Copy link
Member

thinkyhead commented Apr 21, 2016

It's true that these options are a bit too "low level" and confusing for the average user. Some of these options might be hidden behind a simpler config system, similar to the way you now choose an LCD controller, and depending on the one you choose various other options are set.

So let's mull over some possible better names.

We might also be able to do something like this perhaps, in some cases:

#define Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN (Z_MIN_PROBE_PIN == Z_MIN_PIN)

@sarf2k4
Copy link
Author

sarf2k4 commented Apr 22, 2016

I was thinking to go with z probe as z min or use z-probe only for z min probe uses z min endstop pin while for z min probe endstop would be something like this z probe with z min

Not to mention since both of these thing are located way above the auto bed leveling section; homing section that is. I also think that these option would be put under auto bed leveling section since the default hardware setup would be all min endstops anyway and be default not to use z probe.

PS:
I am also want to point out the default pin for ramps 1.4 for using z-probe+z-min concurrently, D32 is located on aux4 while aux4 are primarily used for lcd panel. It should be put either as z-max port or somewhere between aux1-2 since those are rarely used port

@thinkyhead
Copy link
Member

thinkyhead commented Apr 23, 2016

@sarf2k4 I'm not sure what the reasoning is to use D32 for the Z probe pin on RAMPS, so I don't want to jump in and alter it just yet. But maybe I will post a PR suggesting it and see if anyone has objections.

It has been suggested by others recently that we ought to move all the PROBE options out of the AUTO_BED_LEVELING_FEATURE block, and I think that's a good idea. But there are natural worries that if we introduce these options independent of ABL that it will break something. And we want to get 1.1.0 out as soon as we can, so we have to apply triage to things like this and wait for 1.1.1. I have been holding out for perfection, but I think it's a good idea to get 1.1.0 out, reorganize the code, then focus on 1.2 where we can rework things with a little more freedom.

@Blue-Marlin
Copy link
Contributor

Somehow the knowledge got lost, to see the pins-files as user editable configuration files. Since splitting up the huge pin-file, you don't need witchcraft to edit them to your needs.
Despite having said the above, i guess D1 (or D57) on AUX-1 could be the better choice for a default. There you could use ready made endstop plugs with the same order of pins (signal, GND, 5V)

@jbrazio
Copy link
Contributor

jbrazio commented May 7, 2016

To be followed up within PR #3672.

@jbrazio jbrazio closed this as completed May 7, 2016
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Design Concept Technical ideas about ways and methods. T: Development Makefiles, PlatformIO, Python scripts, etc.
Projects
None yet
Development

No branches or pull requests

4 participants