Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add reverse sort of file names on SD #24937

Closed
vovodroid opened this issue Oct 28, 2022 · 3 comments
Closed

[FR] Add reverse sort of file names on SD #24937

vovodroid opened this issue Oct 28, 2022 · 3 comments
Labels
F: SD Card / Media Fix Included A fix is included in the description T: Feature Request Features requested by users.

Comments

@vovodroid
Copy link
Contributor

vovodroid commented Oct 28, 2022

Is your feature request related to a problem? Please describe.

Currently files could be sorted by name, with option recent FAT entry first. So it could be difficult find new file.

Are you looking for hardware support?

No response

Describe the feature you want

Some slicers (at least Prusa) allows add date/time at the file name beginning like 202221028-174608. Reverse sort puts new file at the list top.

Additional context

Actually I built Marlin with such sort. Just changed

#define _SORT_CMP_NODIR() (strcasecmp(sortnames[o1], sortnames[o2]) > 0)
to
#define _SORT_CMP_NODIR() (strcasecmp(sortnames[o1], sortnames[o2]) < 0)
in Marlin/src/sd/cardreader.cpp

I can add config option and create PR if it seems reasonable.

@vovodroid vovodroid added the T: Feature Request Features requested by users. label Oct 28, 2022
@GMagician
Copy link
Contributor

Don't expect an answer. I suggest you to create PR anyway and wait

@vovodroid
Copy link
Contributor Author

PR #25038

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F: SD Card / Media Fix Included A fix is included in the description T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

3 participants