Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] rename u8glib.h to marlin-u8glib.h #22303

Closed
ellensp opened this issue Jul 7, 2021 · 2 comments
Closed

[FR] rename u8glib.h to marlin-u8glib.h #22303

ellensp opened this issue Jul 7, 2021 · 2 comments
Labels
T: Feature Request Features requested by users.

Comments

@ellensp
Copy link
Contributor

ellensp commented Jul 7, 2021

Is your feature request related to a problem? Please describe.

Currently standard u8glib is no longer compatible with marlin, after the addition of the init function.

I purpose that a new fork or branch of https://github.com/MarlinFirmware/U8glib-HAL be created that actually calls itself marlin-u8glib

Are you looking for hardware support?

128x64 based lcd's on arduino ide

Describe the feature you want

Create a new fork or branch of https://github.com/MarlinFirmware/U8glib-HALthat calls itself marlin-u8glib
Leave the old one there to support older versions of marlin under platformio

Then update Marlin to use this new library throughout.

This will stop Arduino IDE users attempting to use the old non compatible u8glib

Further marlin-u8glib could be added to Arduino IDE library manager so users can easily find and install it.

@ellensp ellensp added T: Feature Request Features requested by users. Needs: Discussion Discussion is needed labels Jul 7, 2021
@thinkyhead
Copy link
Member

Arduino IDE should never pick up the wrong header files going forward if we rename the main source and main header files so our include lines become #include <U8glib_hal.h>. Then we just have to make sure we're not mixing in any libraries that expect U8glib.h to be present.

I don't know that we need to give the library a new name. At this time U8glib-HAL is not in the official Arduino library registry, and U8glib-HAL is the name of the library that is already registered with PlatformIO.

So, let's say as a first step we just rename the main source / header files of our U8glib-HAL library, bump the version number, and make that new version a requirement. The new header name will prevent Arduino IDE from trying to use U8glib, and the new version number will ensure that bugfix users pick up the new library on the next compile.

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

2 participants