Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] enable remaining print time for character type displays #18085

Closed
knickohr opened this issue May 23, 2020 · 3 comments
Closed

[FR] enable remaining print time for character type displays #18085

knickohr opened this issue May 23, 2020 · 3 comments
Labels
C: LCD & Controllers T: Feature Request Features requested by users.

Comments

@knickohr
Copy link

knickohr commented May 23, 2020

Hi !

In Marlin 2 I found the remainting print time and status bar calculation. Ist's unfortunately only activated with graphical displays. So why, what*s the difference ? Is it possible to activate it also for character type displays, like the RipRap 2004 LCD controller ?

I've found a quick and dirty workaround, but I have to break and twist the coding stukture and also exchanging a variable in ultralcd_HD44780.cpp. Burt his is not compatible to your coding.

@knickohr knickohr changed the title [FR] enable remainting print time for character type displays [FR] enable remaining print time for character type displays May 23, 2020
@boelle boelle added the T: Feature Request Features requested by users. label Jun 21, 2020
@valeriu-ene
Copy link

This feature is already available in Marlin 2.0.7.2, I'm using it since February, with 20x4 LCD. The gcode must has have M73 commands in it.
Check my pictures below, the feature is working great but it has a small defect related to LCD display.
#21271
(also containing a link to my uploaded config files)

In config file I have enabled:
SDSUPPORT
REPRAP_DISCOUNT_SMART_CONTROLLER

In config_adv I enabled:
LCD_SET_PROGRESS_MANUALLY
SHOW_REMAINING_TIME
USE_M73_REMAINING_TIME
ROTATE_PROGRESS_DISPLAY

I hope this helps.

@thisiskeithb
Copy link
Member

This was implemented in #19416. Closing.

@github-actions
Copy link

github-actions bot commented May 6, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: LCD & Controllers T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

4 participants