Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parameter check for calls to external modules #162

Open
MarkusAmshove opened this issue Mar 15, 2023 · 0 comments · May be fixed by #518
Open

Implement parameter check for calls to external modules #162

MarkusAmshove opened this issue Mar 15, 2023 · 0 comments · May be fixed by #518
Labels
area/typer natparse🔎 Parser and project structure

Comments

@MarkusAmshove
Copy link
Owner

MarkusAmshove commented Mar 15, 2023

Add parameter count and parameter type checks for CALLNAT, PERFORM, etc.

Notes:

  • You can put a numeric field as a parameter to an alphanumeric field, but only if the parameter is specified BY VALUE. Implicit conversions therefore need BY VALUE
  • Do nodes that call external modules need to implement IMutateVariables for the parameter? Or do we opt out of this API and write the check ourselves? They can only be mutated if they're passed by reference
  • If a variable group is passed and a variable group is expected but at some position the types of the variables differ, show the parameter on the module referencing node as the diagnostic position and add the variable from the passing group as additional info (passing this variable) and add the variable from the receiving group as additional info (into this variable)
@MarkusAmshove MarkusAmshove added natparse🔎 Parser and project structure area/typer labels Mar 15, 2023
@MarkusAmshove MarkusAmshove added this to the v0.11 milestone Oct 30, 2023
@MarkusAmshove MarkusAmshove removed this from the v0.11 milestone Nov 23, 2023
@MarkusAmshove MarkusAmshove linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/typer natparse🔎 Parser and project structure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant