Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robotidy should be more verbose #572

Closed
bhirsz opened this issue Aug 30, 2023 · 6 comments · Fixed by #608
Closed

Robotidy should be more verbose #572

bhirsz opened this issue Aug 30, 2023 · 6 comments · Fixed by #608
Labels
enhancement New feature or request

Comments

@bhirsz
Copy link
Member

bhirsz commented Aug 30, 2023

When running default command:

robotidy .

or

robotidy --check .

If nothing is formatted, nothing is printed - and it's not clear that anything actually was run. See black and isort output for example:

black --check .
10:51:22  All done! ✨ 🍰 ✨
10:51:22  35 files would be left unchanged.
isort --check .
10:51:23  Skipped 3 files
@bhirsz bhirsz added the enhancement New feature or request label Aug 30, 2023
@bhirsz
Copy link
Member Author

bhirsz commented Aug 30, 2023

Example output

robotidy .
  3 files reformatted, 140 files left unchanged.

@ssallmen
Copy link

ssallmen commented Dec 21, 2023

Robotidy does not tell about problems even when it detects some, when --check option is used. I would say that this is more of a bug than just enhancement.
Only thing it does is that the return code is False, no output on console whatsoever.

@bhirsz
Copy link
Member Author

bhirsz commented Dec 21, 2023

What about combining - - check and - - diff, does that work?

@ssallmen
Copy link

Yes, with --check --diff I will get what robotidy would fix but that is not good enough. I think it should at least state that some files would need changes, or even which files would be modified like black --check does.

@bhirsz
Copy link
Member Author

bhirsz commented Dec 21, 2023

Yeah, I agree - it will be implemented

@ssallmen
Copy link

Thanks, it would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants