Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional languages to CMAKE_<LANG>_STANDARD_INCLUDE_DIRECTORIES #115

Closed
waldnercharles opened this issue Oct 25, 2024 · 2 comments · Fixed by #118
Closed

Add additional languages to CMAKE_<LANG>_STANDARD_INCLUDE_DIRECTORIES #115

waldnercharles opened this issue Oct 25, 2024 · 2 comments · Fixed by #118

Comments

@waldnercharles
Copy link

I ran into an issue while compiling SDL. The Windows assembler couldn't find a necessary .inc file that was in the Windows SDK include path. At closer inspection, the path wasn't being included for ASM_MASM. Adding it to the loop seems to fix the issue.

Figured I'd open an issue before making a PR in case other languages should be added as well.
@MarkSchofield
Copy link
Owner

Sounds good. There's a few "ASM" variants listed on the documentation for enable_language: "ASM", "ASM_MASM", "ASM_NASM" and "ASM_MARMASM", I think all would be needed...?!

This was referenced Oct 29, 2024
Merged
Merged
@MarkSchofield
Copy link
Owner

I think this has been fixed but with #117, but I'll hold off on closing until I've completed #118.

@MarkSchofield MarkSchofield mentioned this issue Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an example that builds .asm files MarkSchofield/WindowsToolchain
2 participants
@waldnercharles @MarkSchofield