Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new compatible with old #3

Open
MarkEdmondson1234 opened this issue Oct 6, 2018 · 3 comments
Open

Make new compatible with old #3

MarkEdmondson1234 opened this issue Oct 6, 2018 · 3 comments

Comments

@MarkEdmondson1234
Copy link
Owner

I have existing apps and tutorials out there using some of the older functions, so I need to make sure there is at least a deprecation notice on the functions with a suggestion on what to do instead before it hits CRAN.

For example this app should work
https://github.com/MarkEdmondson1234/verbal_ga_shiny/blob/master/app_final.R

Missing functions currently include:

graph_box(boxtitle = "Google Analytics Data",
            subtitle = "Trend",
            dygraphOutput("trend_plot"),
            datepicker = dateRangeInput("datepicker", NULL, start = Sys.Date() - 300))

and

dashboard_box(width = 12, textOutput("text_analysis"), box_title = "Transcript")

Also need to make sure the tracking tags are enabled, which is essential for my live deployed apps, so incorporating this function into the footer somewhere:

trackingTags <- function(tag_template = c("ga","gtm","freeform"),

@MarkEdmondson1234
Copy link
Owner Author

I renamed the new function to gentelellaPageCustom() - there are too many video tutorials and apps using the old function to make it a smooth transition, I will spend the rest of my years supporting them :)

But all the new functionality is all in there, just with renamed function. The old function is quicker to get up and running I think, whilst the new one offers more power and control. Will look at integrating more of the HTML/CSS as I'm sure there are some redundant functions.

@DivadNojnarg
Copy link
Collaborator

Hi Mark,
I missed your message. I agree with your new approach, even though I would have prefered the name gentelellaPagePlus() instead of gentelellaPageCustom(). What do you think about that?
Let me know if you need some help for special tasks.

@MarkEdmondson1234
Copy link
Owner Author

Sure that’s no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants