Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to specify contrasts? #38

Open
liz-is opened this issue Feb 26, 2024 · 1 comment
Open

How to specify contrasts? #38

liz-is opened this issue Feb 26, 2024 · 1 comment

Comments

@liz-is
Copy link

liz-is commented Feb 26, 2024

Hi,

thanks for the cool package, it's been useful and easy to use so far!

I have a control condition and three "treatment" conditions, and I'd like to compare each treatment to control. My condition metadata column is set up as a factor with four levels. I can't figure out how to specify the appropriate contrast as an argument to de_test_neighbourhoods. The documentation for de_test_neighbourhoods says this should be a string, and to look at the edgeR docs for the syntax. In the edgeR docs I see two ways of specifying contrasts: using makeContrasts, or as a numeric vector.

I tried contrasts = "Treat1-Control" by extrapolating from the makeContrasts syntax, but this gave me the following error:

Quitting from lines 267-280 (miloDE.Rmd)                                                                                 
Error in glmFit.default(y, design = design, dispersion = dispersion, offset = offset,  :                                 
  Design matrix not of full rank.  The following coefficients not estimable:                                             
 ConditionTreat1 ConditionTreat2 ConditionTreat3

Any suggestions about what I should be putting instead? I really couldn't find any section in the edgeR docs where they specify contrast as a string. A section reference or an example would be really helpful.

@amissarova
Copy link
Collaborator

Hi @liz-is, apologies for a long silence.

Its hard to answer this wo seeing design model matrix (can you share it perhaps?) - but naively i would assume that you have some redundancy in your matrix. I wonder if the covariates you include n your matrix create such design? So yeah, if you could share with me your design and specifically model matrix you get from this design, I could maybe help a bit more?

So maybe changing the formula to avoid the redundancy would be the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants