-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hub.docker.com Documents incomplete #396
Comments
Noted. I have a moderate set of outstanding documentation things that I should address. If you don't get to this first I'll include this too. Docs are derived from: https://github.com/docker-library/docs/tree/master/mariadb |
Thanks for the URL! Let me see what I can come up with. |
Since this is my first effort at contributing, would you mind giving me some feedback? |
Good start, very small nits commented already. Please keep going, you are doing well. I assume you're going to continue and remove all of the :tag references? If you'd like to do any of the things I was going to do you are most welcome to:
|
Looks pretty fun, let me dive into it and give you some more stuff to review. |
I updated my branch, integrated your suggestions and changes all "tag" tags to "latest". Looking at the other stuff in the next couple of days; I'll probably make a branch for each one and send you the URL for critique. |
Great, squash those and send a PR to https://github.com/docker-library/docs. I'm happy to do review other branches on PRs on that site so the Docker Library people can chip in a review too. |
Not sure what to do on this; thoughts? |
changes should be in mariadb/content.md. readme is autogenerated |
Okay, I'll take care of it in the next day or so. I had seen that the stuff was autogenerated, but didn't see any documentation on how to handle whatever the process was. |
Sorry I got behind, I still have this on my agenda. |
closed by docker-library/docs#2055 Thanks! |
In the "How to use this image" in https://hub.docker.com/_/mariadb, the recommended code doesn't work. It assumes a password for example-user, but doesn't give one. The root user instructions don't seem to work either, but using "root" vice "example-user", with "some-secret-pw" works.
I apologize for not offering a PR for the page, I don't know your document layout yet.
The text was updated successfully, but these errors were encountered: