-
-
Notifications
You must be signed in to change notification settings - Fork 103
[Suggestion] Link to Futbin page of a player #55
Comments
It could also be implemented as a new button next to the 'Search min BIN' button. |
I did some research and currently see no scrict way to get a link to particular player on Futbin. |
Without really touching the details -as it is the first time I see this project -, what about calling the search endpoint that is called on Futbin with the specific player name as an argument and, if there isn't a direct match in the response (aka a unique result), what about doing some direct match with all the rest of the attributes (like rating and position) that are retrieved too? |
Endpoint that futbin uses for the search is: However, that might return multiple results for a single player. Output of a search for De Bruyne gives this:
So that would be a viable option. I've asked Futbin, and they didn't disapprove the use of their service. We just have to take care not to bash their servers too much. Linking would help them get more traffic, so I don't think they would mind. |
@ IvoPereira As I mentioned, making search request is an option I'm just bother of not flooding futbin servers. Each page has 30 items I guess, which is 30 search requests. |
Futbin is not creating custom API endpoints for us, so I've created a local cache based on the endpoint I stated above. It fetches the players based on player name, and matching them on rating. If more than 1 player is found with the same rating, no link is shown for now until I figure out a better way to uniquely identify them. Once a futbin player ID is retrieved, it is stored and not retrieved again, so Futbin doesn't get an overload of requests. |
Fixed in v0.2.1. |
Current version seems to hit a rate limit when searching through the club list. Perhaps need to add the link in the detail panel instead of in the list, so the link can be fetched when an item is selected. |
Fixed in v0.2.2. Introduced a new button in the player detail panel. The futbin link is only determined when you want to open it. |
It would be very useful to be able to click on the current Futbin price icon.
This click would open the Futbin page of the player in a new tab of the browser.
It could be very useful to quickly check the price history of a player.
The text was updated successfully, but these errors were encountered: