Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG in timstof transpose function #307

Merged
merged 2 commits into from
Aug 15, 2024
Merged

BUG in timstof transpose function #307

merged 2 commits into from
Aug 15, 2024

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Aug 15, 2024

Fixed bug where the transposed matrix would approximate the shape incorrectly due to missing values.
Changed testcase to catch this in the future.

Copy link
Collaborator

@odespard odespard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I hope this stops the segmentation faults.

@GeorgWa GeorgWa merged commit d3425ea into development Aug 15, 2024
5 checks passed
@GeorgWa GeorgWa deleted the timstof-transpose branch August 15, 2024 12:42
@GeorgWa GeorgWa added the bug Something isn't working label Sep 12, 2024
@GeorgWa GeorgWa changed the title FIX bug in timstof transpose function BUG in timstof transpose function Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants