Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make error handling automation-friendly #279

Merged
merged 7 commits into from
Jul 30, 2024
Merged

make error handling automation-friendly #279

merged 7 commits into from
Jul 30, 2024

Conversation

mschwoer
Copy link
Collaborator

  • introduce custom error classes
  • centralize and unify error handling
  • write macine-readable error information to events.jsonl

@mschwoer mschwoer requested a review from GeorgWa July 16, 2024 08:19
@GeorgWa GeorgWa changed the base branch from main to development July 16, 2024 11:09
GeorgWa
GeorgWa approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/cli.py Outdated Show resolved Hide resolved
@mschwoer mschwoer requested a review from GeorgWa July 24, 2024 08:17
@GeorgWa GeorgWa mentioned this pull request Jul 25, 2024
Merged
@mschwoer mschwoer merged commit f307e6e into development Jul 30, 2024
4 checks passed
@mschwoer mschwoer deleted the refactor_error_handling branch July 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @GeorgWa