Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#230: ruff rule B905: add strict keyword to zip #246

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

mschwoer
Copy link
Collaborator

@mschwoer mschwoer commented Jun 20, 2024

As discussed: use "strict=True" for all* zips.

*except the one in the njit-decorated method

@mschwoer mschwoer requested a review from GeorgWa June 20, 2024 20:56
Base automatically changed from add-conda-to-docu to development June 21, 2024 07:14
alphadia/features.py Show resolved Hide resolved
alphadia/peakgroup/search.py Show resolved Hide resolved
@GeorgWa GeorgWa added the test:e2e End to end tests will be run on PRs that carry this label. label Jun 21, 2024
@GeorgWa GeorgWa self-requested a review June 21, 2024 12:36
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jalew188
Copy link
Collaborator

This should be applied to all AlphaX if necessary

@mschwoer mschwoer requested a review from GeorgWa June 24, 2024 07:38
@GeorgWa GeorgWa merged commit baedf52 into development Jun 24, 2024
4 checks passed
@GeorgWa GeorgWa deleted the 230-linting-zip branch June 24, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants