Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

230 basic linting rule i2 #244

Merged
merged 1 commit into from
Jun 20, 2024
Merged

230 basic linting rule i2 #244

merged 1 commit into from
Jun 20, 2024

Conversation

mschwoer
Copy link
Collaborator

  • add rule "I" to ruleset
  • make code pass rule "I" (see individual commits)

@mschwoer mschwoer changed the base branch from main to development June 20, 2024 07:07
@GeorgWa GeorgWa added the test:e2e End to end tests will be run on PRs that carry this label. label Jun 20, 2024
GeorgWa
GeorgWa approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mschwoer mschwoer merged commit 3aeecde into development Jun 20, 2024
26 checks passed
@mschwoer mschwoer deleted the 230-basic-linting-rule-i2 branch June 20, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

Assignees
No one assigned
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @GeorgWa