Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

230 basic linting rule f #235

Merged
merged 4 commits into from
Jun 19, 2024
Merged

230 basic linting rule f #235

merged 4 commits into from
Jun 19, 2024

Conversation

mschwoer
Copy link
Collaborator

  • add rule "F" to ruleset
  • make code pass rule "F" (see individual commits)
    @GeorgWa please check carefull all TODOs introduced in here, they might be potential bugs. If not, I'll remove the unused variables in a subsequent PR

@mschwoer mschwoer requested a review from GeorgWa June 18, 2024 07:39
GeorgWa
GeorgWa approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
All changes can be applied apart from the two marked files.

alphadia/outputtransform.py Show resolved Hide resolved
tests/unit_tests/test_fdr.py Show resolved Hide resolved
@mschwoer mschwoer mentioned this pull request Jun 18, 2024
Merged
@mschwoer mschwoer merged commit 03b8fb7 into development Jun 19, 2024
2 checks passed
@mschwoer mschwoer deleted the 230-basic-linting-rule-f branch June 19, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @GeorgWa