156 migrate to pyprojectstoml #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
commented
May 21, 2024
gui/package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "alphadia", | |||
| "productName": "alphadia-gui", | |||
| "version": "1.5.5", | |||
| "version": "1.5.5+test", | |||
There was a problem hiding this comment.
the +test will be dropped again before merging
mschwoer
commented
May 21, 2024
| @@ -12,12 +12,13 @@ conda create -n alphadia_installer python=3.8 -y | |||
| conda activate alphadia_installer | |||
|
|
|||
| # Creating the wheel | |||
| python setup.py sdist bdist_wheel | |||
There was a problem hiding this comment.
can the release_old stuff be deleted, @GeorgWa ?
There was a problem hiding this comment.
yes, all of release old is not used anymore
GeorgWa
approved these changes
May 21, 2024
| @@ -12,12 +12,13 @@ conda create -n alphadia_installer python=3.8 -y | |||
| conda activate alphadia_installer | |||
|
|
|||
| # Creating the wheel | |||
| python setup.py sdist bdist_wheel | |||
There was a problem hiding this comment.
yes, all of release old is not used anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #156 : moves installation to pyproject-based .
Release pipeline worked: https://github.com/MannLabs/alphadia/actions/runs/9178344476
one-click installers need to be checked still -> can be downloaded here https://github.com/MannLabs/alphadia/releases/tag/untagged-08cb77eaa02c3b2abf05