Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE pre-commit hook & code formatting #129

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Apr 22, 2024

No description provided.

@GeorgWa GeorgWa marked this pull request as ready for review April 22, 2024 13:54
@GeorgWa
Copy link
Collaborator Author

GeorgWa commented Apr 22, 2024

Now Black and Ruff are fighting 😆

@GeorgWa GeorgWa requested a review from mschwoer April 22, 2024 13:58
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/black.yml Outdated Show resolved Hide resolved
alphadia/fdr.py Show resolved Hide resolved
pre-commit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we fix the version here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it using https://peps.python.org/pep-0440/#compatible-release
Seemed quite usefull.

@GeorgWa GeorgWa merged commit 340db35 into development Apr 22, 2024
4 checks passed
@GeorgWa GeorgWa deleted the 127-code-formatting branch April 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants