Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby version #351

Closed
PanSpagetka opened this issue Jun 29, 2017 · 1 comment
Closed

Ruby version #351

PanSpagetka opened this issue Jun 29, 2017 · 1 comment

Comments

@PanSpagetka
Copy link

Since we are using ruby version 2.3.3 for Travis, shouldn't @miq-bot use same version? So I can use features like lonely operator without @miq-bot being angry at me :(

@Fryguy
Copy link
Member

Fryguy commented Jun 30, 2017

The reason the bot is 2.2 while the app is 2.3 is because we support Ruby 2.2+ for ManageIQ at the moment (and thus can't support &. at the moment). However, it's too expensive to run both Ruby 2.2 and 2.3 travis builds on all of our PRs. So, the decision was that since we ship our appliances with Ruby 2.3, we run tests with 2.3, and leave rubocop running with 2.2 to catch any syntax errors (&. would appear as a syntax error, since that's not in 2.2).

Once we officially support Ruby 2.4 and it's part of the appliance builds, we will bump the minimum to Ruby 2.3 and make the bot use 2.3. See ManageIQ/manageiq#14446 for progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants