Logging archived targets during C&U collection #17762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slemrmartin
force-pushed
the
metrics-vm-archived-err
branch
2 times, most recently
from
01497da to
0158efe
Compare
|
Cc @blomquisg, @Ladas |
Instead of raising exception due to missing ems_id. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1560691
slemrmartin
force-pushed
the
metrics-vm-archived-err
branch
from
0158efe to
98562b4
Compare
|
Checked commit slemrmartin@98562b4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
reviewed
Aug 3, 2018
There was a problem hiding this comment.
a) I don't think we use ems_id == nil to archive entities anymore. Is this for a backport?
b) I think the reason we don't want to collect these is to avoid a nil ems reference. If we actually did wanted to stop collecting archived vms, we would probably want:
if respond_to?(:ems_id) && ems_id.nil? || try(:deleted_on)
_log.warn ...
return
end
|
a) unfortunately we still use |
Ladas
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when VM is archived, but queued to capture metrics it raises exception due to missing ems_id
Instead of raising exception it'll log message and doesn't try capturing
Links
Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1560691
Steps for Testing/QA
Look at BZ's steps to reproduce.