Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.2 Upgrade #17338

Closed
juliancheal opened this issue Apr 24, 2018 · 13 comments
Closed

Rails 5.2 Upgrade #17338

juliancheal opened this issue Apr 24, 2018 · 13 comments

Comments

@juliancheal
Copy link
Member

juliancheal commented Apr 24, 2018

This issue tracks progress for ManageIQ running Rails 5.2, released April 9, 2018

Rails 5.2 Release Notes
5-1-stable commit list

Known dependencies to be updated:

ManageIQ/manageiq-gems-pending#440
ManageIQ/manageiq-api-client#87
ManageIQ/ovirt_metrics#27
ManageIQ/vmware_web_service#59
ManageIQ/manageiq-providers-openstack#485
ManageIQ/manageiq-ui-classic#5824
ManageIQ/activerecord-virtual_attributes#39

ManageIQ changes

#18449

Release plan

@miq-bot

This comment has been minimized.

@miq-bot

This comment has been minimized.

@miq-bot

This comment has been minimized.

@miq-bot miq-bot added the stale label Oct 29, 2018
@JPrause
Copy link
Member

JPrause commented Nov 21, 2018

@juliancheal is this still an open issue? If not, can you close it.

@juliancheal
Copy link
Member Author

@JPrause Yes it's still open.

@Fryguy Fryguy added pinned and removed stale labels Dec 18, 2018
@juliancheal
Copy link
Member Author

Updating Cops ManageIQ/guides#338

@juliancheal juliancheal changed the title [WIP] Rails 5.2 Upgrade Rails 5.2 Upgrade Jul 17, 2019
@chessbyte
Copy link
Member

@jrafanie can you look into this issue

@juliancheal
Copy link
Member Author

@chessbyte @jrafanie I think the last few issues from stopping us updating to 5.2 is ManageIQ/activerecord-virtual_attributes#39

@djberg96
Copy link
Contributor

djberg96 commented Jan 6, 2020

@juliancheal, @jrafanie Is this done?

@jrafanie
Copy link
Member

jrafanie commented Jan 6, 2020

No, I believe the only thing left was in activerecord virtual attributes. @kbrock do you know where we stand there with 5.2 support? Are we ready to try to get master on that?

@kbrock
Copy link
Member

kbrock commented Jan 17, 2020

Sigh, I've been dragging.

Think it requires a pre 5.1 version, a 5.2 version, and a 6.0 version.

I need to get back to this

@kbrock
Copy link
Member

kbrock commented Mar 26, 2020

Ok, I got that one pesky test passing for 5.2 ==> ManageIQ/activerecord-virtual_attributes#62

Lets see how those cross repo tests work, then we'll continue on the miq issues

@chessbyte
Copy link
Member

Addressed via #20032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants