Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Do not queue C&U collection for things that do not support C&U #15193

Closed
isimluk opened this issue May 23, 2017 · 1 comment
Closed

Performance: Do not queue C&U collection for things that do not support C&U #15193

isimluk opened this issue May 23, 2017 · 1 comment
Assignees
@isimluk

Comments

@isimluk
Copy link
Member

isimluk commented May 23, 2017 •
edited
Loading

I have noticed these two occurrences:

  • When you have hyperv (scvmm) it cannot capture C&U, but we schedule perf_capture_* into queue anyway (and it fails horribly)
  • When you have rhev without the authentication_type(:metrics), we schedule perf_capture_* into queue (and then it fails horribly).

We could save a lot of memory and CPU cycles in these cases.
@isimluk isimluk mentioned this issue May 23, 2017
Merged
@gmcculloug gmcculloug assigned gmcculloug and isimluk and unassigned gmcculloug Jun 8, 2017
@gmcculloug
Copy link
Member

Fixed in #15194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isimluk isimluk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmcculloug @isimluk