From 666ad9826d984268ec6c3df2570ff89e9325506f Mon Sep 17 00:00:00 2001 From: Madhu Kanoor Date: Wed, 1 Mar 2017 17:28:38 -0500 Subject: [PATCH] PR feedback --- .../20170222214902_add_initiator_to_service.rb | 1 + .../20170222214902_add_initiator_to_service_spec.rb | 12 ------------ 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/db/migrate/20170222214902_add_initiator_to_service.rb b/db/migrate/20170222214902_add_initiator_to_service.rb index 8d5066c53ab..19a6ac28915 100644 --- a/db/migrate/20170222214902_add_initiator_to_service.rb +++ b/db/migrate/20170222214902_add_initiator_to_service.rb @@ -1,5 +1,6 @@ class AddInitiatorToService < ActiveRecord::Migration[5.0] class Service < ActiveRecord::Base; end + def up add_column :services, :initiator, :string, :comment => "Entity that initiated the service creation" say_with_time("Updating existing services to 'user' initiator") do diff --git a/spec/migrations/20170222214902_add_initiator_to_service_spec.rb b/spec/migrations/20170222214902_add_initiator_to_service_spec.rb index 3d781c824be..2e4239074ca 100644 --- a/spec/migrations/20170222214902_add_initiator_to_service_spec.rb +++ b/spec/migrations/20170222214902_add_initiator_to_service_spec.rb @@ -16,16 +16,4 @@ expect(service_stub.find_by(:name => 'service2').initiator).to eq(default_initiator) end end - - migration_context :down do - it "removes initiator" do - service_stub.create!(:name => 'service1', :initiator => default_initiator) - service_stub.create!(:name => 'service2', :initiator => default_initiator) - - migrate - - expect(service_stub.count).to eq(2) - expect(service_stub.columns.collect(&:name).exclude?('initiator')).to be_truthy - end - end end